Skip to content

[Improvement]: Supplement mock and merge code#2841

Merged
zhoujinsong merged 3 commits into
apache:masterfrom
zhangmo8:master
May 17, 2024
Merged

[Improvement]: Supplement mock and merge code#2841
zhoujinsong merged 3 commits into
apache:masterfrom
zhangmo8:master

Conversation

@zhangmo8

@zhangmo8 zhangmo8 commented May 17, 2024

Copy link
Copy Markdown
Member

Why are the changes needed?

Supplement mock and merge code

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added the module:ams-dashboard Ams dashboard module label May 17, 2024

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit bb56cfe into apache:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-dashboard Ams dashboard module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants