Skip to content

[AMORO-2853] Improve the packaging and compilation process for amoro project#2854

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
xleoken:skipTrino
May 23, 2024
Merged

[AMORO-2853] Improve the packaging and compilation process for amoro project#2854
zhoujinsong merged 1 commit into
apache:masterfrom
xleoken:skipTrino

Conversation

@xleoken

@xleoken xleoken commented May 21, 2024

Copy link
Copy Markdown
Member

Why are the changes needed?

Close #2853.

Brief change log

It not friendly for users to use mvn clean package -DskipTests -pl '!amoro-mixed-format/amoro-mixed-format-trino' to build the amoro project. Add a new skip-trino-build profile to improve the build command.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added type:docs Improvements or additions to documentation module:mixed-trino trino module for Mixed Format type:infra type:build labels May 21, 2024
@xleoken

xleoken commented May 21, 2024

Copy link
Copy Markdown
Member Author

cc @zhoujinsong

@xleoken xleoken marked this pull request as draft May 22, 2024 06:38
@xleoken xleoken marked this pull request as ready for review May 22, 2024 07:01
@xleoken xleoken changed the title [AMORO-2853] Add skip-trino-build profile [AMORO-2853] Improve the packaging and compilation process for amoro project May 22, 2024
@xleoken

xleoken commented May 22, 2024

Copy link
Copy Markdown
Member Author

Hi @zhoujinsong for the suggestion. Patch is updated accordingly, can you please take another look?

Had tried following mvn commad in local environment.

  • Execute mvn clean package to package all modules except amoro-mixed-format-trino.
  • Execute mvn clean package -Pbuild-mixed-format-trino -Ptoolchain to package all modules.
  • Execute mvn clean package -Pbuild-mixed-format-trino -pl 'amoro-mixed-format/amoro-mixed-format-trino' -am to package amoro-mixed-format-trino only.

Originally posted by @zhoujinsong in #2853 (comment)

@xleoken xleoken marked this pull request as draft May 23, 2024 01:59
@xleoken xleoken marked this pull request as ready for review May 23, 2024 03:08

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks a lot for the contribution!

@zhoujinsong zhoujinsong merged commit b8e98e2 into apache:master May 23, 2024
@xleoken xleoken deleted the skipTrino branch June 4, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:mixed-trino trino module for Mixed Format type:build type:docs Improvements or additions to documentation type:infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Add skip-trino-build profile

2 participants