[AMORO-1528] Add metrics document#2859
Merged
Merged
Conversation
github-actions
Bot
added
the
type:docs
xxubai
reviewed
May 23, 2024
xxubai
left a comment
xxubai
left a comment
Contributor
There was a problem hiding this comment.
I drop some comments, PTAL
| - full: means that full optimizing is being executed on the table. | ||
| - committing: means that self-optimizing process is being committed. | ||
| - **Duration**: The duration of the current status. | ||
| - **File Count**: The total number of files involved in the current Self-optimizing, including base, insert, eq-delete, and pos-delete file types. |
Contributor
There was a problem hiding this comment.
Suggested change
| - **File Count**: The total number of files involved in the current Self-optimizing, including base, insert, eq-delete, and pos-delete file types. | |
| - **File Count**: The total number of files involved in the current self-optimizing, including base, insert, eq-delete, and pos-delete file types. |
Contributor
There was a problem hiding this comment.
Should we describe it in more detail? For example with a self-optimising process?
Contributor
Author
There was a problem hiding this comment.
Do you mean that we can add some description about the optimizing process tab in the table detail page here?
If yes, maybe we can add it in another PR.
Co-authored-by: Xavier Bai <tocreationbai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Add a document for metrics.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation