Skip to content

[AMORO-3112]Use the same mysql transaction to handle multiple database operations#3114

Closed
rfyu wants to merge 3 commits intoapache:masterfrom
rfyu:amoro-3112
Closed

[AMORO-3112]Use the same mysql transaction to handle multiple database operations#3114
rfyu wants to merge 3 commits intoapache:masterfrom
rfyu:amoro-3112

Conversation

@rfyu
Copy link
Contributor

@rfyu rfyu commented Aug 19, 2024

Why are the changes needed?

Close #3112.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Aug 19, 2024
@rfyu rfyu closed this Aug 19, 2024
@rfyu rfyu reopened this Aug 19, 2024
TransactionFactory transactionFactory = new JdbcTransactionFactory();
Environment environment = new Environment("develop", transactionFactory, dataSource);
Configuration configuration = new Configuration(environment);
configuration.setDefaultExecutorType(org.apache.ibatis.session.ExecutorType.BATCH);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this configuration only affects the statement object usage, it will not affect the transaction scope.

So I don't think we can solve the lock issue with this change.

@github-actions
Copy link

github-actions bot commented Oct 3, 2024

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 3, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 11, 2024
@zhoujinsong zhoujinsong reopened this Oct 11, 2024
@github-actions github-actions bot removed the stale label Oct 12, 2024
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 11, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Use the same mysql transaction to handle multiple database operations

3 participants