Skip to content

[AMORO-3112]Use the same mysql transaction to handle multiple database operations #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rfyu wants to merge 3 commits into from
Closed

[AMORO-3112]Use the same mysql transaction to handle multiple database operations #3114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a5405a
[AMORO-3112]Use the same mysql transaction to handle multiple databas…
rfyu Aug 19, 2024
3ca937f
Merge branch 'master' into amoro-3112
baiyangtx Aug 26, 2024
ff360e2
Merge branch 'master' into amoro-3112
zhoujinsong Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...s-server/src/main/java/org/apache/amoro/server/persistence/SqlSessionFactoryProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public void init(Configurations config) {
TransactionFactory transactionFactory = new JdbcTransactionFactory();
Environment environment = new Environment("develop", transactionFactory, dataSource);
Configuration configuration = new Configuration(environment);
configuration.setDefaultExecutorType(org.apache.ibatis.session.ExecutorType.BATCH);
Copy link
Contributor

@zhoujinsong zhoujinsong Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this configuration only affects the statement object usage, it will not affect the transaction scope.

So I don't think we can solve the lock issue with this change.

configuration.addMapper(TableMetaMapper.class);
configuration.addMapper(OptimizingMapper.class);
configuration.addMapper(CatalogMetaMapper.class);
Expand Down