[AMORO-2099][amoro-web] Remove default Glue lock configuration - #4305
Merged
zhoujinsong merged 1 commit intoAug 3, 2026
Merged
Conversation
xxubai
marked this pull request as ready for review
July 31, 2026 06:09
xxubai
added a commit
that referenced
this pull request
Aug 6, 2026
[amoro-web] Remove default Glue lock configuration (cherry picked from commit a0640e0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The Glue Catalog form currently adds
lock-implandlock.tableas default properties. Because the properties form requires non-empty values, users must configure an external lock manager even though the current Iceberg and AWS SDK versions support Glue optimistic locking through the tableversionId.This makes Glue Catalog creation require unnecessary DynamoDB lock configuration. Iceberg 1.7.2 automatically uses Glue optimistic locking when
lock-implis absent, and Amoro uses AWS SDK 2.24.12, which provides the requiredversionIdAPI.This is a follow-up to #2099, where the lock properties were originally added to the dashboard.
Brief change log
lock-implandlock.tableas default properties for new Glue Catalogs.warehouseas the only default Glue Catalog property.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Validation performed:
pnpm buildpassed.git diff --checkpassed.pnpm lintwas run and reported 137 existing repository lint problems unrelated to this one-line change.Documentation