Skip to content

[AMORO-2099][amoro-web] Remove default Glue lock configuration - #4305

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
xxubai:codex/remove-default-glue-lock-config
Aug 3, 2026
Merged

[AMORO-2099][amoro-web] Remove default Glue lock configuration#4305
zhoujinsong merged 1 commit into
apache:masterfrom
xxubai:codex/remove-default-glue-lock-config

Conversation

@xxubai

@xxubai xxubai commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

The Glue Catalog form currently adds lock-impl and lock.table as default properties. Because the properties form requires non-empty values, users must configure an external lock manager even though the current Iceberg and AWS SDK versions support Glue optimistic locking through the table versionId.

This makes Glue Catalog creation require unnecessary DynamoDB lock configuration. Iceberg 1.7.2 automatically uses Glue optimistic locking when lock-impl is absent, and Amoro uses AWS SDK 2.24.12, which provides the required versionId API.

This is a follow-up to #2099, where the lock properties were originally added to the dashboard.

Brief change log

  • Stop adding lock-impl and lock.table as default properties for new Glue Catalogs.
  • Keep warehouse as the only default Glue Catalog property.
  • Preserve the generic Properties editor so existing or explicitly configured external lock settings remain supported.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Validation performed:

  • pnpm build passed.
  • git diff --check passed.
  • pnpm lint was run and reported 137 existing repository lint problems unrelated to this one-line change.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@xxubai
xxubai marked this pull request as ready for review July 31, 2026 06:09
@github-actions github-actions Bot added the module:ams-dashboard Ams dashboard module label Jul 31, 2026

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong
zhoujinsong merged commit a0640e0 into apache:master Aug 3, 2026
1 check passed
xxubai added a commit that referenced this pull request Aug 6, 2026
[amoro-web] Remove default Glue lock configuration

(cherry picked from commit a0640e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-dashboard Ams dashboard module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants