[AMORO-4303][AMS] Stabilize optimizer heartbeat tests - #4307
Open
johntomcat7408-cmyk wants to merge 1 commit into
Open
[AMORO-4303][AMS] Stabilize optimizer heartbeat tests#4307johntomcat7408-cmyk wants to merge 1 commit into
johntomcat7408-cmyk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4303.
AMSServiceTestBaseapplied an 800 ms optimizer heartbeat timeout to every optimizer test, while its background toucher only attempted a heartbeat every 300 ms. Under CI scheduling or database delays, tests that were not exercising expiration could lose the optimizer, requeue its task, and fail nondeterministically.Brief change log
How was this patch tested?
Validation performed against commit
7efadacadc3561b60ec7c10cc28e91964c29e5a8:TestDefaultOptimizingServicesuite (22 tests) passed, followed by 20/20 successful repetitions oftestPollTaskThreeTimes.TestDefaultOptimizingServicesuite (22 tests) passed, followed by 20/20 successful repetitions oftestPollTaskThreeTimes.Documentation