-
Notifications
You must be signed in to change notification settings - Fork 575
feat: added github link to header #1632 #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI not responding @juzhiyuan |
|
This PR will resolve backend CI |
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
+ Coverage 72.38% 73.90% +1.51%
==========================================
Files 134 87 -47
Lines 5737 2621 -3116
Branches 665 665
==========================================
- Hits 4153 1937 -2216
+ Misses 1341 684 -657
+ Partials 243 0 -243
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
juzhiyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also cc @nic-chen to review
|
need two more approvals @juzhiyuan |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Github hyperlink(icon) added has been added to header section of login page
User will be directed to https://apisix.apache.org.
Please update this section with detailed description.
Github hyperlink(icon) has been added to header section of login page
User will be directed to https://apisix.apache.org.
fix/resolve #1632
Checklist:
screenshot of changes done
@LiteSun @juzhiyuan