Skip to content

Conversation

@iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented Mar 23, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Github hyperlink(icon) added has been added to header section of login page
User will be directed to https://apisix.apache.org.

Please update this section with detailed description.
Github hyperlink(icon) has been added to header section of login page
User will be directed to https://apisix.apache.org.

fix/resolve #1632

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

screenshot of changes done
@LiteSun @juzhiyuan

screencapture-172-20-10-3-8000-user-login-2021-03-23-09_08_39

@iamayushdas
Copy link
Contributor Author

CI not responding @juzhiyuan

@iamayushdas iamayushdas mentioned this pull request Mar 23, 2021
4 tasks
@juzhiyuan
Copy link
Member

#1649

This PR will resolve backend CI

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #1650 (0d226c3) into master (85efb37) will increase coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
+ Coverage   72.38%   73.90%   +1.51%     
==========================================
  Files         134       87      -47     
  Lines        5737     2621    -3116     
  Branches      665      665              
==========================================
- Hits         4153     1937    -2216     
+ Misses       1341      684     -657     
+ Partials      243        0     -243     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 73.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/User/Login.tsx 72.00% <ø> (ø)
api/internal/core/store/store.go
api/internal/handler/server_info/server_info.go
api/internal/filter/request_id.go
api/internal/utils/consts/api_error.go
api/internal/handler/tool/tool.go
api/internal/handler/healthz/healthz.go
api/internal/conf/conf.go
api/internal/filter/ip_filter.go
...pi/internal/handler/plugin_config/plugin_config.go
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85efb37...0d226c3. Read the comment docs.

@iamayushdas
Copy link
Contributor Author

iamayushdas commented Mar 23, 2021

#1649

This PR will resolve backend CI

I added the google cloud container registry to the repo as stated in #1649. I hope that won't be a issue?

@juzhiyuan juzhiyuan requested a review from nic-chen March 23, 2021 05:55
@nic-chen
Copy link
Member

I added the google cloud container registry to the repo as stated in #1649. I hope that won't be a issue?

#1649 has been merged, please sync codes from branch master

@iamayushdas
Copy link
Contributor Author

I added the google cloud container registry to the repo as stated in #1649. I hope that won't be a issue?

#1649 has been merged, please sync codes from branch master

✅ okay

@iamayushdas
Copy link
Contributor Author

I added the google cloud container registry to the repo as stated in #1649. I hope that won't be a issue?

#1649 has been merged, please sync codes from branch master

okay

done

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also cc @nic-chen to review

@iamayushdas
Copy link
Contributor Author

need two more approvals @juzhiyuan

@juzhiyuan juzhiyuan requested review from Jaycean and liuxiran March 23, 2021 11:46
@juzhiyuan juzhiyuan merged commit 83335e2 into apache:master Mar 23, 2021
@iamayushdas iamayushdas deleted the github_in_header branch March 23, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve some minor issues

6 participants