Skip to content

Conversation

@foolwc
Copy link
Contributor

@foolwc foolwc commented Aug 18, 2021

Changes:
Replace styled <a> with <div>

Screenshots of the change:
截屏2021-08-18 下午10 09 36

In addition, maybe it would look better by placing the plugin icon image horizontal center

@netlify
Copy link

netlify bot commented Aug 18, 2021

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: c8eb0b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/611d189bdb64a30007977a46

😎 Browse the preview: https://deploy-preview-478--apisix.netlify.app

@1502shivam-singh
Copy link
Member

In addition, maybe it would look better by placing the plugin icon image horizontal center

Agreed, they are not centered completely, feel free to solve this issue. Also one more thing if you could help out with would be really nice (no compulsion), can you reduce the sizes of the plugin thumbnails so that all of them look of the same sizes and bit smaller (currently the icons seem too packed inside the card with less white space all around)

@liuxiran
Copy link
Contributor

Thanks for @foolwc

In addition, maybe it would look better by placing the plugin icon image horizontal center

Agreed, they are not centered completely, feel free to solve this issue. Also one more thing if you could help out with would be really nice (no compulsion), can you reduce the sizes of the plugin thumbnails so that all of them look of the same sizes and bit smaller (currently the icons seem too packed inside the card with less white space all around)

Good suggestion @1502shivam-singh ~! we can make a new pr to improve our plugins page, just create an issue: #484 to trace it, and welcome pr.

@juzhiyuan juzhiyuan merged commit d892ac8 into apache:master Aug 19, 2021
@foolwc foolwc deleted the descendant-a branch August 19, 2021 08:18
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants