feat: lang detection #970
Merged
feat: lang detection #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apache-apisix ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bzp2010
reviewed
Mar 24, 2022
juzhiyuan
reviewed
Mar 25, 2022
Member
juzhiyuan
left a comment
juzhiyuan
left a comment
There was a problem hiding this comment.
Hi, @SkyeYoung. This PR has lots of style changes. 😅 How about this?
- You could set up the prettier configuration and format all codes in one PR.
- Submit this lang detection PR without extra codes style changes.
Member
Author
Ok, I'll rollback it. I'm adding lint tools. :D |
Contributor
|
I found a strange problem. My broswer is in Chinese mode. Page will be redirect to the
|
Member
Author
I have tried to solve this problem. Pls have a look. |
SkyeYoung
force-pushed
the
fix-issue-743
branch
from
6a50954 to
65fb7f1
Compare
bzp2010
previously approved these changes
Mar 28, 2022
bzp2010
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #743
Changes:
pls check #743 (comment)
I didn't add a re-enable button, because after thinking, I find the step of detecting the language automatically should only happen when I first entered the website.
Screenshots of the change:
none, pls check preview.
Logic of Language Redirect:
