fix(loki-logger): encrypt the headers field - #13784
Merged
Merged
Conversation
The headers field carries the Loki/Grafana Cloud Authorization token but was not in encrypt_fields, so it was stored in plaintext in etcd and returned unmasked, unlike the identically-shaped elasticsearch-logger headers. Add headers to encrypt_fields.
dosubot
Bot
added
size:M
AlinsRan
approved these changes
Aug 7, 2026
shreemaan-abhishek
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
loki-loggerheadersfield is the documented place for the Loki / Grafana CloudAuthorizationtoken, and it is copied verbatim into the outbound request. Butheadersis not listed in the plugin'sencrypt_fields, so the token is stored in plaintext in etcd and returned unmasked from the Admin API — unlike the identically-shapedelasticsearch-loggerheaders, which is encrypted.This adds
headerstoloki-logger'sencrypt_fields, matchingelasticsearch-logger.Checklist