feat(deployment): send the right Host & SNI #7323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tzssangglass
approved these changes
Jun 27, 2022
soulbird
reviewed
Jun 27, 2022
| ngx_var.upstream_host = res.domain or res.host | ||
| if balancer.recreate_request and ngx.get_phase() == "balancer" then | ||
| balancer.recreate_request() | ||
| end |
Member
Author
There was a problem hiding this comment.
So we can use a new Host, see https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#recreate_request
bzp2010
approved these changes
Jun 27, 2022
soulbird
approved these changes
Jun 27, 2022
spacewander
added a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander spacewanderlzx@gmail.com
Description
Fixes # (issue)
Checklist