fix: response-rewrite plugin might cause Apache AIPSIX hanging #7727

Hazel6869 · 2022-08-17T23:58:47Z

Description

Fixes # (issue)

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

…#7621) * Update README.md Co-authored-by: Ming Wen <moonbingbing@gmail.com> Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com> Co-authored-by: Ming Wen <moonbingbing@gmail.com>

spacewander · 2022-08-19T09:15:38Z

t/plugin/response-rewrite.t

+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.response-rewrite")
+            local ok, err = plugin.check_schema({


The newly added test doesn't cover the changed part?

@Hazel6869 You should write another case which really uses the configuration.

spacewander · 2022-08-19T09:16:18Z

Please put the issue id after Fixes # so it can be linked.

tzssangglass · 2022-08-19T09:20:26Z

t/plugin/response-rewrite.t

+=== TEST 25: set an nil body with setting body_base64 to false
+--- config
+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.response-rewrite")
+            local ok, err = plugin.check_schema({
+                            body_base64 = false
+            })
+            if not ok then
+                ngx.say(err)
+                return
+            end
+        }
+    }
+--- request
+GET /t
+--- response_body
+
+--- no_error_log
+[error]


This test case would have passed even without the code changes.

…pache#7717)

* docs: refactor kafka-logger plugin doc * Update docs/zh/latest/plugins/kafka-logger.md Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com> Co-authored-by: hf400159 <hf400159@163.com> Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>

* docs: refactor rocketmq-logger plugin doc * docs: fix typo * docs: update keywords Co-authored-by: hf400159 <hf400159@163.com>

…recated (apache#7768)

* docs: update request-id.md

* docs: update request-validation.md

* docs: refactor loggers plugin doc * Update docs/zh/latest/plugins/clickhouse-logger.md Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com> Co-authored-by: hf400159 <hf400159@163.com> Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>

* docs: update loggly Co-authored-by: hf400159 <hf400159@163.com>

* docs: update Architecture docs * move deployment guide and reference in installation docs * add license header

tokers · 2022-08-29T09:53:41Z

t/plugin/response-rewrite.t



-=== TEST 25: set an nil body with setting body_base64 to false
+=== TEST 25: set header(rewrite body with "")


Suggested change

=== TEST 25: set header(rewrite body with "")

=== TEST 25: set header and rewrite body to empty

…isix_xl into fix_response_rewrite_plugin # Conflicts: # t/plugin/response-rewrite.t

tzssangglass · 2022-08-30T02:36:18Z

hi @Hazel6869 I think you merged the branches by mistake.

Hazel6869 · 2022-08-30T10:11:02Z

hi @Hazel6869 I think you merged the branches by mistake.

i will fix it, thanks

fix: response rewrite policy

b54d87d

Hazel6869 marked this pull request as draft August 18, 2022 00:14

juzhiyuan and others added 5 commits August 18, 2022 09:28

docs: update expired Slack link (apache#7725)

86e9a8e

fix test

d0c0d7a

change: move the disable to _meta (apache#7707)

bc9af92

update powered-by.md (apache#7474)

1fb458f

fix blank line

ab9b048

Hazel6869 changed the title ~~feat: upgrade response rewrite policy and add test cases~~ feat: upgrade response rewrite plugin and add test cases Aug 18, 2022

tzssangglass and others added 2 commits August 18, 2022 17:51

change: drop support for port_admin (apache#7716)

024ed5a

fix: recovery old pb state after pubsub.new (apache#7728)

308bdd9

Hazel6869 marked this pull request as ready for review August 19, 2022 03:07

docs: fix README.md file and the name should be Apache APISIX (apache…

29f21a0

…#7621) * Update README.md Co-authored-by: Ming Wen <moonbingbing@gmail.com> Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com> Co-authored-by: Ming Wen <moonbingbing@gmail.com>

spacewander reviewed Aug 19, 2022

View reviewed changes

tzssangglass reviewed Aug 19, 2022

View reviewed changes

tzssangglass and others added 15 commits August 22, 2022 09:33

change: drop support for enable_http2 and listen_port in apisix.ssl (a…

167b655

…pache#7717)

change(authz-keycloak): remove deprecated audience (apache#7683)

d353801

feat: release 2.13.3 (apache#7744)

df82304

chore: ensure the total topics are <= 20 (apache#7755)

04b8afc

docs: refactor rocketmq-logger plugin doc (apache#7687)

ba7e6a3

* docs: refactor rocketmq-logger plugin doc * docs: fix typo * docs: update keywords Co-authored-by: hf400159 <hf400159@163.com>

ci: update Ubuntu to 20.04 as 18.04 was deprecated (apache#7766)

3047a2b

ci: change base JDK images to eclipse-temurin as openjdk is being dep…

bc6cd4f

…recated (apache#7768)

docs(plugin): refactor request-id.md (apache#7751)

e17cdba

* docs: update request-id.md

docs(plugin): refactor request-validation.md (apache#7752)

a49f339

* docs: update request-validation.md

docs: refactor loggers plugin doc (2) (apache#7708)

1aeb3a6

* docs: update loggly Co-authored-by: hf400159 <hf400159@163.com>

docs: update Architecture docs (apache#7568)

cd51174

* docs: update Architecture docs * move deployment guide and reference in installation docs * add license header

feat: add workflow plugin(mvp) (apache#7760)

1cf96d1

docs(http-logger): fix attributes (apache#7721)

6f1a64d

tzssangglass and others added 7 commits August 29, 2022 14:43

feat(workflow): support limit count action (apache#7771)

cffa4b6

fix test

1bfdc48

fix test

5c3d258

fix test

8b06d4b

fix test

c19ab3c

fix test

c95782c

fix test

d8406a9

tokers reviewed Aug 29, 2022

View reviewed changes

Hazel6869 added 18 commits August 29, 2022 22:26

fix GET

6cb5646

fix: response rewrite policy

398ecb3

fix test

4f021cd

fix blank line

36d7428

fix test

f22d156

fix test cese

7276d35

fix test case

1b1e356

fix test cases

bdc3b1d

fix test title

18642c5

fix test

5f96696

fix test

4c24f2e

fix test

8239414

fix test

cffe36f

fix test

ef26d71

fix test

3084412

fix GET

6c77b62

fix test

822be86

Merge branch 'fix_response_rewrite_plugin' of github.com:Hazel6869/ap…

7b60a3d

…isix_xl into fix_response_rewrite_plugin # Conflicts: # t/plugin/response-rewrite.t

Hazel6869 marked this pull request as draft August 30, 2022 02:32

Hazel6869 closed this Sep 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: response-rewrite plugin might cause Apache AIPSIX hanging #7727

fix: response-rewrite plugin might cause Apache AIPSIX hanging #7727

Uh oh!

Hazel6869 commented Aug 17, 2022 •

edited

Loading

Uh oh!

spacewander Aug 19, 2022

Uh oh!

tokers Aug 25, 2022

Uh oh!

spacewander commented Aug 19, 2022

Uh oh!

tzssangglass Aug 19, 2022

Uh oh!

tokers Aug 29, 2022

Uh oh!

tzssangglass commented Aug 30, 2022

Uh oh!

Hazel6869 commented Aug 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants



		=== TEST 25: set an nil body with setting body_base64 to false
		=== TEST 25: set header(rewrite body with "")

	=== TEST 25: set header(rewrite body with "")
	=== TEST 25: set header and rewrite body to empty

fix: response-rewrite plugin might cause Apache AIPSIX hanging #7727

fix: response-rewrite plugin might cause Apache AIPSIX hanging #7727

Uh oh!

Conversation

Hazel6869 commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

spacewander Aug 19, 2022

Choose a reason for hiding this comment

Uh oh!

tokers Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

spacewander commented Aug 19, 2022

Uh oh!

tzssangglass Aug 19, 2022

Choose a reason for hiding this comment

Uh oh!

tokers Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

tzssangglass commented Aug 30, 2022

Uh oh!

Hazel6869 commented Aug 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Hazel6869 commented Aug 17, 2022 •

edited

Loading