Skip to content

Conversation

@ffang
Copy link
Contributor

@ffang ffang commented Aug 27, 2020

No description provided.

@jbonofre jbonofre self-requested a review August 28, 2020 06:14
@jbonofre jbonofre merged commit 3f3df2b into apache:trunk Aug 28, 2020
@rmannibucau
Copy link

Hi guys,
wonder if the logic shouldn't be to visit the original class to grab the original class version and fallback on the jvm version (as in https://github.com/apache/openwebbeans/blob/master/webbeans-impl/src/main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java#L429)
Otherwise it can happen it does not work (global version can not proxy specific version in some particular cases).

hope it makes sense

@jbonofre
Copy link
Member

@rmannibucau yeah, that could be a smarter design to avoid to change utils any time we have a new JDK. I will do that once 1.1.8 is out. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants