Skip to content

chore(c/validation): add FloatCastTypeName quirk for CAST(... AS FLOAT) #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fornwall wants to merge 1 commit into from
+7 −2
Closed

chore(c/validation): add FloatCastTypeName quirk for CAST(... AS FLOAT) #4492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions c/validation/adbc_validation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ class DriverQuirks {
/// \brief Return the SQL to reference the bind parameter of the given index
virtual std::string BindParameter(int index) const { return "?"; }

/// \brief SQL type name for a 64-bit floating-point CAST target.
virtual std::string FloatCastTypeName() const { return "FLOAT"; }

/// \brief For a given Arrow type of ingested data, what Arrow type
/// will the database return when that column is selected?
virtual ArrowType IngestSelectRoundTripType(ArrowType ingest_type) const {
Expand Down
6 changes: 4 additions & 2 deletions c/validation/adbc_validation_statement.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2333,7 +2333,8 @@ void StatementTest::TestSqlQueryInts() {

void StatementTest::TestSqlQueryFloats() {
ASSERT_THAT(AdbcStatementNew(&connection, &statement, &error), IsOkStatus(&error));
ASSERT_THAT(AdbcStatementSetSqlQuery(&statement, "SELECT CAST(1.5 AS FLOAT)", &error),
std::string query = "SELECT CAST(1.5 AS " + quirks()->FloatCastTypeName() + ")";
ASSERT_THAT(AdbcStatementSetSqlQuery(&statement, query.c_str(), &error),
IsOkStatus(&error));

{
Expand Down Expand Up @@ -2730,7 +2731,8 @@ void StatementTest::TestSqlSchemaFloats() {
}

ASSERT_THAT(AdbcStatementNew(&connection, &statement, &error), IsOkStatus(&error));
ASSERT_THAT(AdbcStatementSetSqlQuery(&statement, "SELECT CAST(1.5 AS FLOAT)", &error),
std::string query = "SELECT CAST(1.5 AS " + quirks()->FloatCastTypeName() + ")";
ASSERT_THAT(AdbcStatementSetSqlQuery(&statement, query.c_str(), &error),
IsOkStatus(&error));

nanoarrow::UniqueSchema schema;
Expand Down
Loading