chore(c/validation): allow >1 partition in TestSqlPartitionedInts#4493
Merged
Conversation
fornwall
changed the title
TestSqlPartitionedInts hardcoded ASSERT_EQ(1, num_partitions), which is not true for all engines (Spanner reports 2 here - one of them being empty). Accept >=1 partitions and assert on the the union of all partitions. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
fornwall
force-pushed
the
validation/partition-count-ge
branch
from
e2317f5 to
bcf52e2
Compare
lidavidm
approved these changes
Jul 9, 2026
fornwall
added a commit
to fornwall/adbc-spanner
that referenced
this pull request
Jul 9, 2026
…onedInts (#213) apache/arrow-adbc#4493 relaxed TestSqlPartitionedInts from a hardcoded ASSERT_EQ(1, num_partitions) to allowing >=1 partitions and asserting on the union of all of them, so Spanner (whose partitionQuery may return more than one — the emulator returns 2) now passes it. Bump ARROW_ADBC_TAG in adbc-validation/CMakeLists.txt from the apache-arrow-adbc-23 release tag to the main revision that carries the fix (f9886ddca13a2ea2f044a453216b3973b66cd98f, current main HEAD), and drop SpannerStatementTest.SqlPartitionedInts from the EXCLUDED list so the gate enforces it. Docs updated to match (README bucket note + gate count 44->45). Verified against a throwaway emulator: gate 47 passed / 1 self-skip / 0 fail, expected-failure guard clean (52 excluded still fail-or-skip), stale guard clean, and SqlPartitionedInts passes in isolation. Claude-Session: https://claude.ai/code/session_01EMPx5dY5oYwNEP6fsViqu5 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestSqlPartitionedIntshardcodedASSERT_EQ(1, num_partitions), which is not true for all engines (Spanner reports 2 here - one of them being empty).Accept
>=1partitions and assert on the the union of all partitions.