fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut#4497
Open
fornwall wants to merge 2 commits into
Open
fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut#4497fornwall wants to merge 2 commits into
fornwall wants to merge 2 commits into
Conversation
It seems that AddressSanitizer (ASan) here hangs CI at: - Native Libraries (Unix) / C/C++ (Conda/macos-latest) Example run on latest main branch commit at time of writing: - https://github.com/apache/arrow-adbc/actions/runs/28991039011/job/86030648737 Disable ASan on macos-latest for now to work around that. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
… DoPut The FlightSQL test server's DoPutPreparedStatementQuery handler returned without consuming the client's bound-parameter request stream. gRPC tears the stream down as soon as the handler returns, so on a slow/oversubscribed runner (observed on arm64 macOS CI) the client's in-flight parameter send races the teardown and surfaces as a spurious "EOF (Unknown; ExecuteQuery)" instead of the real response, flaking test_stateless_prepared_statement. Drain the reader before returning so the handler consumes the full request stream, per gRPC's contract, removing the race. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
Member
|
Good find here, but the client should also be fixed to not just report an EOF, if your agent can figure that out... |
Contributor
Author
|
This includes the changes in #4495, as that is necessary to unblock CI and reach the test that this PR aims to fix. But that change can be reviewed and merged in isolation - this test failure surfaces after that fix, but is AFAIK separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FlightSQL test server's
DoPutPreparedStatementQueryhandler returned without consuming the client's bound-parameter request stream. gRPC tears the stream down as soon as the handler returns, so it might happen that (observed on arm64 macOS CI) the client's in-flight parameter send races the teardown and surfaces as a spurious "EOF (Unknown; ExecuteQuery)" instead of the real response, flakingtest_stateless_prepared_statement.Drain the reader before returning so the handler consumes the full request stream, per gRPC's contract, removing the race.