feat(go/adbc): refactor logging instrumentation into OTel tracing - part 3/3 - #4661
Draft
birschick-bq wants to merge 13 commits into
Draft
Conversation
… dev/birschick-bq/flight-sql-log-to-trace-4-connection
… dev/birschick-bq/flight-sql-log-to-trace-5-statements
…into dev/birschick-bq/flight-sql-log-to-trace-5-statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the FlightSQL driver's statement execution and bulk ingest logic to improve observability by replacing custom logging with structured OpenTelemetry tracing. It introduces detailed span events and attributes for all major statement operations, ensures errors are properly recorded, and fingerprints queries in a privacy-preserving way. The changes also update key helper functions to generate OpenTelemetry attributes and clean up legacy logging code.
Tracing and Observability Improvements:
SetSqlQuery,ExecuteQuery,ExecuteUpdate,Prepare, and bulk ingest) now create OpenTelemetry spans, add structured events/attributes, and record errors with stack traces for better traceability.sloghas been removed from statement execution paths in favor of OpenTelemetry events and attributes.API and Helper Updates:
queryAttrs,flightInfoTracingKeyValues, and correlation header attribute generators have been updated to return OpenTelemetryattribute.KeyValueslices instead of genericanyslices.Testing:
Extends: #4659
Part 3/3