fix(arrow/ipc): make writer failures terminal - #1047
Merged
zeroshade merged 9 commits intoAug 7, 2026
Conversation
zeroshade
requested changes
Aug 5, 2026
zeroshade
reviewed
Aug 5, 2026
zeroshade
reviewed
Aug 5, 2026
zeroshade
reviewed
Aug 5, 2026
zeroshade
reviewed
Aug 5, 2026
Comment on lines
+65
to
+68
| func writeFull(w io.Writer, p []byte) error { | ||
| _, err := w.Write(p) | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
at this point why even have the writeFull function instead of just putting everything back to being _, err = w.Write(paddingBytes[:padding]) etc.?
zeroshade
approved these changes
Aug 5, 2026
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/ipc-writer-terminal-errors
branch
from
August 5, 2026 23:37
29c742d to
91322f2
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
An IPC writer can fail after writing part of a schema, dictionary, or record payload. The writer must not continue with stale state or lose the first failure.
What changes are included in this PR?
Keep the first terminal error, mark the writer as started before schema payloads are written, close a started payload writer exactly once, preserve close and panic failures, and release retained dictionaries. Closing without a schema still returns arrow.ErrInvalid.
Are these changes tested?
go test ./arrow/ipcAre there any user-facing changes?
Yes. After a terminal write or close failure, later writes return the stored error instead of continuing with stale writer state.