Skip to content

fix(parquet/pqarrow): propagate level builder errors - #1049

Merged
zeroshade merged 2 commits into
apache:mainfrom
fallintoplace:fix/pqarrow-propagate-level-builder-errors
Aug 5, 2026
Merged

fix(parquet/pqarrow): propagate level builder errors#1049
zeroshade merged 2 commits into
apache:mainfrom
fallintoplace:fix/pqarrow-propagate-level-builder-errors

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return errors from multipath level builder construction instead of reporting a successful column write
  • release builders created for earlier chunks when a later chunk fails
  • release partially initialized builder state on visitor errors
  • leave the physical column position unchanged after builder construction fails

Testing

  • go test ./parquet/pqarrow

The regression test uses a valid dictionary chunk followed by a dictionary containing a null, which reaches the previously swallowed error path, verifies checked allocator cleanup, and successfully retries the same physical column with supported data.

@fallintoplace
fallintoplace requested a review from zeroshade as a code owner July 28, 2026 23:35
@zeroshade
zeroshade merged commit 8ed90de into apache:main Aug 5, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants