fix(arrow/util): release protobuf enum dictionaries - #1083
Merged
zeroshade merged 1 commit intoAug 5, 2026
Conversation
fallintoplace
force-pushed
the
fix/protobuf-enum-dictionary-cleanup
branch
from
August 1, 2026 22:50
72a2d8d to
9280452
Compare
zeroshade
approved these changes
Aug 5, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM — clean, minimal leak fix.
getDictValuesnowdefer bldr.Release()s the temp string builder; since thedeferruns afterbldr.NewArray()computes the return value, the returned array keeps the transferred buffers and the builder's own allocation is freed.- The DICTIONARY path releases
dictValuesafterInsertStringDictValuescopies from it, and before theerrcheck, so the error path doesn't leak either. - The regression test is a real reproduction: with the fix it passes, and reverting
protobuf_reflect.gomakes the checked allocator reportLEAK of 64 bytesfor the temp builder/array.
Verified locally: go test ./arrow/util passes with no regressions. (The go vet note on protobuf_reflect.go:199 about copying a protobuf Any lock is pre-existing and unrelated to this change.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Release the temporary string builder and array used to initialize protobuf enum dictionaries.
Why
InsertStringDictValuescopies values from its input. The temporary builder and array remained owned by the conversion path and leaked after each enum append.Testing
go test ./arrow/util