fix(arrow/util): release protobuf record builders - #1084
Merged
Conversation
fallintoplace
force-pushed
the
fix/protobuf-record-cleanup
branch
from
August 1, 2026 22:50
9d8d858 to
de03bd0
Compare
zeroshade
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Construct protobuf records through
RecordBuilder.NewRecordBatchand release the builder after ownership transfers to the returned record. Record test helpers now release returned batches as well.Why
The manual conversion retained the record builder, each temporary field array, and the intermediate struct array. Releasing the returned record did not release those extra references.
Testing
go test ./arrow/util