fix(arrow/util): handle invalid protobuf Any values - #1086
Merged
Conversation
fallintoplace
force-pushed
the
fix/protobuf-any-errors
branch
from
August 1, 2026 22:50
37aaa0f to
1ff0889
Compare
zeroshade
approved these changes
Aug 5, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Just need to fix the merge conflicts
fallintoplace
force-pushed
the
fix/protobuf-any-errors
branch
from
August 5, 2026 18:49
1ff0889 to
914d93d
Compare
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/protobuf-any-errors
branch
from
August 5, 2026 23:48
914d93d to
08287f0
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
An unknown protobuf Any type URL or invalid payload can leave the unpacked message nil. The schema conversion path then dereferences it instead of preserving the physical Any fields.
What changes are included in this PR?
Handle unpacking errors and fall back to reflecting type_url and value. Avoid copying protobuf message state during conversion.
Are these changes tested?
go test ./arrow/utilAre there any user-facing changes?
No API changes. This corrects the reported behavior while preserving the existing ownership and compatibility contracts.