fix(compute): round negative HalfToOdd ties correctly - #1094
Merged
zeroshade merged 1 commit intoAug 6, 2026
Conversation
zeroshade
approved these changes
Aug 5, 2026
fallintoplace
changed the title
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The decimal HalfToOdd kernel uses the remainder sign incorrectly when adjusting negative ties. Some negative values therefore round to an even result instead of the nearest odd result.
What changes are included in this PR?
Use the signed remainder when choosing the adjustment for Decimal128 and Decimal256. Leave round_to_multiple unchanged.
Are these changes tested?
go test ./arrow/compute/...Are there any user-facing changes?
No API changes. This corrects the reported behavior while preserving the existing ownership and compatibility contracts.