fix(arrow/scalar): use wide offsets for large binary scalars - #1108
Open
fallintoplace wants to merge 3 commits into
Open
fix(arrow/scalar): use wide offsets for large binary scalars#1108fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
fallintoplace
changed the title
zeroshade
requested changes
Aug 7, 2026
| createOffsets := func(valLength int64) *memory.Buffer { | ||
| buffer := memory.NewResizableBuffer(mem) | ||
| buffer.Resize(arrow.Int32Traits.BytesRequired(length + 1)) | ||
| if sc.DataType().ID() == arrow.LARGE_BINARY || sc.DataType().ID() == arrow.LARGE_STRING { |
Member
There was a problem hiding this comment.
do we also need to check for LARGE_LIST?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
MakeArrayFromScalar currently uses 32-bit offsets for every binary-like scalar. LargeBinary and LargeString require 64-bit offsets, so their arrays can have the wrong physical layout.
What changes are included in this PR?
Select the offset width from the scalar type and test ordinary and large binary values, including validation and buffer size.
Are these changes tested?
go test ./arrow/scalarAre there any user-facing changes?
No API changes. This corrects the reported behavior while preserving the existing ownership and compatibility contracts.