Skip to content

fix(arrow/scalar): align timestamp timezone parsing - #1109

Draft
fallintoplace wants to merge 7 commits into
apache:mainfrom
fallintoplace:fix/scalar-parse-timestamp-timezone
Draft

fix(arrow/scalar): align timestamp timezone parsing#1109
fallintoplace wants to merge 7 commits into
apache:mainfrom
fallintoplace:fix/scalar-parse-timestamp-timezone

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

MakeScalarParam and ParseScalar should handle timestamp timezone metadata consistently. The shared parsing path needs to support Arrow fixed-offset timezone strings without regressing the existing case-insensitive UTC behavior.

What changes are included in this PR?

  • Reuse TimestampType.GetZone for non-UTC timestamp metadata.
  • Keep UTC, utc, and mixed-case forms such as Utc on the existing timezone-neutral path.
  • Require an explicit offset when a non-UTC timezone type is used, while preserving the instant represented by an offset in the value.
  • Add coverage for invalid timezone metadata and timezone-less values for zoned types.

Are these changes tested?

  • go test ./arrow/scalar

Are there any user-facing changes?

Timestamp scalar parsing now validates non-UTC timezone metadata and rejects timezone-less values for zoned types. Explicit offsets in the input determine the instant. Mixed-case UTC timezone metadata remains accepted.

@fallintoplace fallintoplace changed the title fix(arrow/scalar): honor timestamp timezones in ParseScalar fix(arrow/scalar): honor timezones in ParseScalar Aug 5, 2026
@fallintoplace fallintoplace changed the title fix(arrow/scalar): honor timezones in ParseScalar fix(arrow/scalar): parse zoned timestamps consistently Aug 6, 2026
@fallintoplace
fallintoplace marked this pull request as draft August 7, 2026 10:16
@fallintoplace fallintoplace changed the title fix(arrow/scalar): parse zoned timestamps consistently fix(arrow/scalar): align timestamp timezone parsing Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant