fix(arrow/scalar): apply timestamp zones when casting to dates - #1110
Open
fallintoplace wants to merge 2 commits into
Open
fix(arrow/scalar): apply timestamp zones when casting to dates#1110fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
zeroshade
requested changes
Aug 7, 2026
| millis := arrow.ConvertTimestampValue(s.Unit(), arrow.Millisecond, int64(s.Value)) | ||
| return NewDate32Scalar(arrow.Date32(millis / int64(millisecondsInDay))), nil | ||
| timestampType := s.DataType().(*arrow.TimestampType) | ||
| toTime, err := timestampType.GetToTimeFunc() |
Member
There was a problem hiding this comment.
the toTime func should already be handling the timestamp offset by using .In, so we shouldn't need to separately add the offset like you're doing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Timestamp-to-Date32 and timestamp-to-Date64 casts use integer arithmetic that truncates negative values and ignores the timestamp timezone.
What changes are included in this PR?
Convert timestamps through the timestamp type's time semantics and reuse the date normalization used by the compute cast path. Add regression coverage around the Unix epoch and a named timezone.
Are these changes tested?
go test ./arrow/scalarAre there any user-facing changes?
No API changes. This corrects the reported behavior while preserving the existing ownership and compatibility contracts.