fix(arrow/scalar): release partial children after failed struct extraction - #1118
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/scalar): release partial children after failed struct extraction#1118fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/scalar-getscalar-cleanup
branch
from
August 6, 2026 17:36
74cc0db to
d36a051
Compare
zeroshade
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GetScalar can create children before a later Struct child fails conversion. Returning immediately leaves the children already created on the error path unreleased.
What changes are included in this PR?
Release partial children when extraction fails while preserving ownership for a successfully built struct scalar. The regression test uses a list child followed by an unsupported view child.
Are these changes tested?
go test ./arrow/scalarAre there any user-facing changes?
No API changes. This corrects the reported behavior while preserving the existing ownership and compatibility contracts.