fix(compute): detect temporal rounding overflow - #1127
Draft
fallintoplace wants to merge 9 commits into
Draft
Conversation
fallintoplace
force-pushed
the
fix/temporal-rounding-overflow
branch
from
August 6, 2026 19:45
2fb9343 to
65f4e12
Compare
fallintoplace
force-pushed
the
fix/temporal-rounding-overflow
branch
from
August 7, 2026 21:01
65f4e12 to
71e18ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Temporal rounding can overflow while converting timestamps to nanoseconds, calculating the rounding interval, or multiplying a rounded quotient. The current unchecked arithmetic can return an incorrect timestamp.
What changes are included in this PR?
Use checked arithmetic for temporal conversions, interval setup, rounding results, calendar conversion, and origin adjustments. Propagate overflow as an Arrow invalid-value error.
Are these changes tested?
go test ./arrow/computeAre there any user-facing changes?
Inputs and options that cannot be represented during temporal rounding now return an error instead of a wrapped result.