fix(arrow/ipc): preserve minSpaceSavings in stream writer - #1143
Merged
zeroshade merged 1 commit intoAug 11, 2026
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:52
zeroshade
approved these changes
Aug 11, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM — NewWriter now propagates minSpaceSavings consistently with the payload and file writer constructors, so the public stream writer honors WithMinSpaceSavings.
I ran the constructor regression 100 times, a public stream API threshold probe 50 times, focused race tests, and the full arrow/ipc package on head 5a31fbd246b8; all passed. CI is fully green with 23 of 23 checks passing.
This review was drafted by an AI-assisted tool and confirmed by an Apache Arrow Go maintainer. The maintainer approving this PR has read the findings and signed off. If something feels off, please reply on the PR and a maintainer will follow up.
More on how Apache Arrow Go handles maintainer review: CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
NewWriterWithPayloadWritercopiesminSpaceSavings, butNewWriterdid not. As a result,WithMinSpaceSavingswas ignored by the regular stream writer.What changes are included in this PR?
Copy the configured value in
NewWriterand add a regression test.Are these changes tested?
go test ./arrow/ipcAre there any user-facing changes?
The regular IPC stream writer now honors
WithMinSpaceSavings.