fix(arrow/csv): preserve first row during headerless inference - #1145
Merged
zeroshade merged 1 commit intoAug 11, 2026
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:52
zeroshade
approved these changes
Aug 11, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
The headerless inference fix looks correct. The pending row is copied safely despite ReuseRecord, and it is replayed exactly once across single-row, chunked, and read-all modes.
I exercised the chunk modes, single-row and filtered-column cases, focused stress and race tests, the CSV package, and the full arrow/... subtree on head 2b3b88faca7e; all passed. CI is green.
This review was drafted by an AI-assisted tool and confirmed by an Apache Arrow Go maintainer. The maintainer approving this PR has read the findings and signed off. If something feels off, please reply on the PR and a maintainer will follow up.
More on how Apache Arrow Go handles maintainer review: CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When schema inference runs with WithHeader(false), the first CSV record is consumed while generating f0, f1, and so on, but it is not sent through the builders. This patch keeps that record pending and replays it through the normal reader path.
Test