perf(parquet): batch delta binary packed decoding - #1169
Draft
fallintoplace wants to merge 1 commit into
Draft
Conversation
fallintoplace
marked this pull request as draft
August 11, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DELTA_BINARY_PACKED decoding called
BitReader.GetBatchonce for every value in a miniblock. The miniblock is already the unit decoded by this code, so this missed the existing batch unpackers.What changes are included in this PR?
GetBatchcallAre these changes tested?
Yes. I ran the full Parquet test tree with the parquet-testing fixtures, the internal utility and encoding tests with
noasm, and a linux/amd64 cross-build.Apple M1 Pro results for 65,536 values with
GOMAXPROCS=1and 10 samples:Allocations stay at 2 allocs/op in all four benchmarks.