perf(arrow/array): batch dictionary empty appends - #1223
Merged
zeroshade merged 2 commits intoAug 28, 2026
Conversation
zeroshade
requested changes
Aug 28, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
The batching change preserves behavior in the tested cases and reproduces the expected performance and allocation improvements. Array, repeated dictionary, race, vet, and LSP checks pass. One lint failure must be fixed before merge.
| panic(err) | ||
| } | ||
|
|
||
| b.idxBuilder.Builder.Reserve(n) |
Member
There was a problem hiding this comment.
The repository’s lint hook rewrites this to b.idxBuilder.Reserve(n), causing the required Lint check to fail because the hook modifies the file. Please use the promoted method and rerun lint.
zeroshade
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
AppendEmptyValuesused to build ann-element values array and dictionary-encode every empty value.Benchmark
Command:
Apple M1 Pro, Go 1.26.3. The benchmark reuses the dictionary builder and resets the output length between iterations.
Tests
go test ./arrow/array -count=1go test ./arrow/... ./internal/...