perf(arrow/array): concatenate bitmaps directly - #1224
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
zeroshade
requested changes
Aug 28, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
The performance and allocation improvements reproduce, and the normal-input correctness, race, vet, LSP, and CI checks pass. One error-path allocation regression needs correction before merge.
| if bm.data == nil { // if the bitmap is nil, that implies that the value is true for all elements | ||
| bitutil.SetBitsTo(out.Bytes(), int64(offset), int64(bm.rng.len), true) | ||
| for _, d := range data { | ||
| if buf := d.Buffers()[idx]; buf == nil { // if the bitmap is nil, that implies that the value is true for all elements |
Member
There was a problem hiding this comment.
out has already been allocated here. If an ArrayData implementation lacks buffer slot idx, this access panics; the outer recovery returns an error, but the local buffer is unreachable and leaked. A checked-allocator probe retains 64 bytes on this head versus 0 on the base. Please release out on panic/error after allocation and add a checked-allocator regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
concatused to build a temporary[]bitmapfor each bitmap it concatenated.concatBitmapsnow reads the inputArrayDatadirectly by buffer index.Benchmark
Command:
Apple M1 Pro, Go 1.26.3. The benchmark concatenates 65,536 rows split across 64, 1,024, and 8,192 chunks.
Tests
go test ./arrow/array -count=1go test ./arrow/... ./internal/...