perf(arrow/array): copy same-dictionary indices directly - #1225
Merged
zeroshade merged 1 commit intoAug 28, 2026
Conversation
zeroshade
approved these changes
Aug 28, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
This change safely reuses the fixed-width concatenation path for same-dictionary indices and substantially reduces allocations for large chunk counts. I verified parity across index widths, slices, offsets, nulls, empty inputs, equal-but-distinct dictionaries, and dictionary unification. Array, repeated, race, vet, and LSP checks pass; CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
concatFixedWidthBuffersdirectly for the dictionary indices.Benchmark
Command:
Apple M1 Pro, Go 1.26.3. The benchmark concatenates 65,536 rows with the same four-value string dictionary, split across different chunk counts.
Tests
go test ./arrow/array -count=1go test ./arrow/... ./internal/...