perf(arrow/array): bulk append BinaryView nulls - #1232
Merged
zeroshade merged 1 commit intoAug 28, 2026
Conversation
zeroshade
requested changes
Aug 28, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
The bitmap optimization and performance improvement are reproducible, and normal parity, race, and allocation checks pass. However, the new bulk path can silently corrupt builder state when the requested count overflows its length arithmetic.
| return | ||
| } | ||
|
|
||
| b.Reserve(n) |
Member
There was a problem hiding this comment.
Please reject counts that would overflow b.length + n before calling Reserve.
With one existing value, AppendNulls(math.MaxInt) now returns with Len() == math.MinInt and NullN() == math.MaxInt. NewBinaryViewArray() then produces a negative-length array whose ValidateFull() still returns nil. A guard such as n > math.MaxInt-b.length, plus boundary regression coverage, would prevent this silent corruption.
fallintoplace
force-pushed
the
perf/arrow-binaryview-append-nulls
branch
from
August 28, 2026 18:11
edfbeef to
616998d
Compare
zeroshade
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BinaryViewBuilder.AppendNullswith one bulk bitmap update.Benchmark
Apple M1 Pro, Go 1.26.3. The builder is preallocated and reused, so this measures the bitmap append itself. Medians from 5 runs at offset 0:
Command:
go test -vet=off ./arrow/array -run "^$" -bench "^BenchmarkBinaryViewBuilderAppendNulls$" -benchmem -benchtime=500ms -count=5 -cpu=1Both versions use 0 B/op and 0 allocs/op in this preallocated benchmark.
Tests
go test ./arrow/array -count=1PARQUET_TEST_DATA=parquet-testing/data go test ./... -count=1