Skip to content

test(parquet): reduce macOS race test memory pressure - #1275

Open
zeroshade wants to merge 1 commit into
apache:mainfrom
zeroshade:fix/macos-parquet-oom
Open

test(parquet): reduce macOS race test memory pressure#1275
zeroshade wants to merge 1 commit into
apache:mainfrom
zeroshade:fix/macos-parquet-oom

Conversation

@zeroshade

Copy link
Copy Markdown
Member

Rationale for this change

The macOS test jobs run on 7 GB ARM64 runners and intermittently kill parquet/file while running under the race detector. Two large-value regression tests each write more than 1 GB and retained all encoded output in memory. Package-level parallelism adds further pressure.

Example failure: https://github.com/apache/arrow-go/actions/runs/33590782213/job/100362942846?pr=1241

What changes are included in this PR?

  • Replace the retained bytes.Buffer output in the two large-value tests with a counting writer.
  • Run Parquet packages serially (-p=1) on Darwin to bound package-level memory pressure.
  • Correct both macOS job names from AMD64 to ARM64.

Are these changes tested?

  • go test -race -tags assert ./parquet/file -count=1
  • go test -race -tags assert,noasm ./parquet/file -count=1
  • bash -n ci/scripts/test.sh
  • git diff --check

Both formerly high-memory tests also passed independently under -race -tags assert,noasm.

Are there any user-facing changes?

No.

Avoid retaining gigabyte-sized Parquet output in regression tests, serialize Parquet package tests on constrained macOS ARM64 runners, and correct the CI job labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants