ci: use bundled GTest for conda integration - #1277
Merged
Merged
Conversation
Signed-off-by: Matt Topol <matt@columnar.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Conda integration workflow overrides Apache Arrow's
GTest_SOURCE=BUNDLEDimage configuration withSYSTEM. That can compile integration tests against Conda GTest headers while linking the bundled/different-version library, producing intermittenttesting::internal::AssertHelperundefined-symbol failures.What changes are included in this PR?
Remove the workflow override so the upstream
conda-cppimage's explicitGTest_SOURCE=BUNDLEDsetting is used consistently for headers and libraries.Are these changes tested?
actionlint .github/workflows/test.yml(excluding unrelated existing ShellCheck findings)git diff --checkThe complete Conda integration image is exercised by CI.
Are there any user-facing changes?
No.