perf(internal/utils): add ARM64 NEON min/max for 8- and 16-bit integers - #1281
Merged
zeroshade merged 1 commit intoSep 3, 2026
Merged
Conversation
fallintoplace
force-pushed
the
perf/internal-utils-arm64-neon-minmax
branch
from
September 2, 2026 22:06
e4d5fb8 to
c312f3c
Compare
zeroshade
approved these changes
Sep 3, 2026
Member
There was a problem hiding this comment.
Verified locally on Apple M1: native NEON tests, -race, noasm parity, and an amd64 compile check all pass. Dispatch correctly guards on ASIMD detection with scalar tails and fallback.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Arrow Go maintainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noasmis used.Benchmark
Apple M1 Pro, n=65536, median of 3 runs:
Checks
go test ./internal/utils -count=1go test -race ./internal/utils -count=1go test -tags noasm ./internal/utils -count=1ARM_ENABLE_EXT=bogus go test ./internal/utils -count=1go vet ./internal/utilsGOARCH=amd64 go test -c -o /dev/null ./internal/utils