perf(compute): vectorize numeric to boolean casts - #1282
Merged
zeroshade merged 1 commit intoSep 3, 2026
Conversation
zeroshade
approved these changes
Sep 3, 2026
Member
There was a problem hiding this comment.
Verified locally on Apple M1: the NEON path is exercised natively and passes, including NaN, signed zero, infinities, sliced inputs, and bitmap tails; noasm parity passes. Reusing the existing comparison kernel keeps the semantics aligned with the scalar isNonZero path.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Arrow Go maintainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
array != scalarcomparison kernel to produce the output bitmap.Benchmark
Apple M1 Pro,
GOMAXPROCS=1, compared with-tags noasm.Tests
go test ./arrow/compute ./arrow/compute/internal/kernelsgo test -tags noasm ./arrow/compute ./arrow/compute/internal/kernels