fix(parquet/variant): handle empty metadata keys#985
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/variant-empty-key
branch
from
July 23, 2026 00:53
efa6d4c to
09defe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Variant metadata may contain an empty object key.
Metadata.KeyAtvalidates the dictionary index, then previously took the address of the key's first byte. That panics when the key is empty.What changes are included in this PR?
Use
unsafe.SliceDatafor the existing zero-copy byte-to-string conversion so zero-length keys are handled safely. Add a builder-based regression covering bothKeyAtandIdFor.Are these changes tested?
Yes:
go test ./parquet/variantgo test -race -count=1 ./parquet/variantAre there any user-facing changes?
Metadata.KeyAtnow returns an empty string for a valid empty key instead of panicking. There is no API change.