fix(arrow/ipc): propagate CLI stream errors#986
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/ipc-cli-stream-errors
branch
from
July 23, 2026 00:53
76d13cd to
7ff60cd
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow-catandarrow-lsstopped whenReader.Nextreturned false but did not inspectReader.Err. A record read failure could therefore be reported as a successful end of stream.arrow-catcould exit successfully after partial output, whilearrow-lscould print a record count for an incomplete stream.What changes are included in this PR?
Check
Reader.Errafter iteration in both commands and return it after releasing the reader.arrow-lsnow prints the record count only after the stream completes successfully. Regression tests use a valid schema followed by truncated record metadata.Are these changes tested?
Yes:
go test ./arrow/ipc/cmd/arrow-cat ./arrow/ipc/cmd/arrow-lsgo test -race -count=1 ./arrow/ipc/cmd/arrow-cat ./arrow/ipc/cmd/arrow-lsAre there any user-facing changes?
Both command-line tools now return an error for a failed record read instead of reporting success. Valid stream output is unchanged.