fix(internal/utils): handle reader reset and short peeks#987
Open
fallintoplace wants to merge 1 commit into
Open
fix(internal/utils): handle reader reset and short peeks#987fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
force-pushed
the
fix/buffered-reader-state
branch
from
July 23, 2026 00:53
207ca4b to
203bc74
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The internal buffered reader can retain a deferred error when an underlying
Readreturns data and an error together.Resetreplaced the underlying reader but left that error pending, so the next read could return the old error without touching the new input.Peekalso returned the requested-length slice when input ended early, exposing unused buffer bytes instead of only the bytes that were read.What changes are included in this PR?
Clear pending read errors in
Reset, and clamp shortPeekresults to the number of buffered bytes. Regression tests cover reuse after a data-plus-error read and a partial peek at EOF.Are these changes tested?
Yes:
go test ./internal/utilsgo test -race -count=1 ./internal/utilsAre there any user-facing changes?
Buffered Parquet reads no longer carry an error across reader reuse or expose unused bytes from a short peek. There is no public API change.