fix(arrow/flight): avoid blocking after stream cancellation#989
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/flight): avoid blocking after stream cancellation#989fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
force-pushed
the
fix/flight-stream-error-cancellation
branch
from
July 23, 2026 00:53
b023b81 to
1662249
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
StreamChunksFromReaderobserves context cancellation while sending record batches, but its final reader-error send still wrote directly to the output channel. If the consumer stopped receiving after cancellation, that send could block forever, preventing reader release and channel closure. This is a follow-up to the cancellation handling added in #615.What changes are included in this PR?
Race final error delivery against context cancellation, matching the existing record-batch send behavior. Capture the reader error once before delivery. Add a regression with an already-canceled context, an unbuffered channel, and a reader that fails immediately.
Are these changes tested?
Yes:
go test ./arrow/flightgo test -race -count=1 ./arrow/flightAre there any user-facing changes?
StreamChunksFromReadernow returns promptly and releases its reader when cancellation prevents final error delivery. Error delivery is unchanged while the context remains active.