chore: reduce lock hold time in DefaultObjectStoreRegistry::deregister#792
Merged
Merged
Conversation
Compute the URL key and path segments before acquiring the write lock, so the lock is only held for the actual map mutation.
kszucs
changed the title
kylebarron
approved these changes
Jul 8, 2026
Contributor
|
🚀 Thanks @kszucs and @kylebarron |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
deregisteracquired the write lock before computing the URL key andpath segments, unnecessarily extending the time the lock is held.
What changes are included in this PR?
Move the
url_keyand path segment computation ahead of the writelock acquisition in
DefaultObjectStoreRegistry::deregister, so thelock is only held for the actual map mutation.
Are there any user-facing changes?
No.