Add fallible mutable buffer methods#10329
Open
cetra3 wants to merge 1 commit into
Open
Conversation
cetra3
force-pushed
the
fallible_mutable_buffer_methods
branch
from
036cc88 to
fb8519d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Allocations should have fallible methods to go alongside their standard panicking methods.
What changes are included in this PR?
Adjusts the internals of
MutableBufferto add new fallible methods that are used by the existing public APIs, so no breaking changes specifically for existing users.Are these changes tested?
Yes they are tested
Are there any user-facing changes?
Yes, there are new methods added to
MutableBuffer