chore: Deprecate ParquetObjectReader / ParquetObjectWriter, add object_store example#10398
Draft
alamb wants to merge 2 commits into
Draft
chore: Deprecate ParquetObjectReader / ParquetObjectWriter, add object_store example#10398alamb wants to merge 2 commits into
ParquetObjectReader / ParquetObjectWriter, add object_store example#10398alamb wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#10354 proposes removing the
object_storeintegration from theparquetcrate to slim down the dependency chain.Removing
ParquetObjectReader/ParquetObjectWriterwithout notice will cause downstream pain , so per this discussion and the deprecation policy we should actually deprecate the API for at least 2 major releases before we remove themWhat changes are included in this PR?
ParquetObjectReaderandParquetObjectWriteras of version 60.0.0, with notes pointing at the new exampleparquet/examples/object_store.rs, a runnable, self-contained copy of the reader/writer implementations (and their tests) that users can copy/paste into their own cratesAre these changes tested?
yes by CI
Are there any user-facing changes?
Yes:
ParquetObjectReaderandParquetObjectWriterare now marked deprecated. No functionality is removed yet.