Skip to content

fix(arrow-schema): stop asserting on unstable TryFromIntError message in tests #10433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jul 25, 2026
+9 −9
Merged

fix(arrow-schema): stop asserting on unstable TryFromIntError message in tests #10433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions arrow-schema/src/datatype_parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ mod test {
// too large for i32
(
"FixedSizeBinary(4000000000), ",
"Error converting 4000000000 into i32 for FixedSizeBinary: out of range integral type conversion attempted",
"Error converting 4000000000 into i32 for FixedSizeBinary:",
),
// can't have negative width
(
Expand All @@ -1503,35 +1503,35 @@ mod test {
// can't have negative precision
(
"Decimal32(-3, 5)",
"Error converting -3 into u8 for Decimal32: out of range integral type conversion attempted",
"Error converting -3 into u8 for Decimal32:",
),
(
"Decimal64(-3, 5)",
"Error converting -3 into u8 for Decimal64: out of range integral type conversion attempted",
"Error converting -3 into u8 for Decimal64:",
),
(
"Decimal128(-3, 5)",
"Error converting -3 into u8 for Decimal128: out of range integral type conversion attempted",
"Error converting -3 into u8 for Decimal128:",
),
(
"Decimal256(-3, 5)",
"Error converting -3 into u8 for Decimal256: out of range integral type conversion attempted",
"Error converting -3 into u8 for Decimal256:",
),
(
"Decimal32(3, 500)",
"Error converting 500 into i8 for Decimal32: out of range integral type conversion attempted",
"Error converting 500 into i8 for Decimal32:",
),
(
"Decimal64(3, 500)",
"Error converting 500 into i8 for Decimal64: out of range integral type conversion attempted",
"Error converting 500 into i8 for Decimal64:",
),
(
"Decimal128(3, 500)",
"Error converting 500 into i8 for Decimal128: out of range integral type conversion attempted",
"Error converting 500 into i8 for Decimal128:",
),
(
"Decimal256(3, 500)",
"Error converting 500 into i8 for Decimal256: out of range integral type conversion attempted",
"Error converting 500 into i8 for Decimal256:",
),
("Struct(f1 Int64)", "Error unknown token: f1"),
("Struct(\"f1\" Int64)", "Expected ':'"),
Expand Down
Loading