GH-10613: Fix IPC FileReader projected schema - #10627
Merged
Jefffrey merged 1 commit intoAug 12, 2026
Merged
Conversation
Jefffrey
approved these changes
Aug 12, 2026
Contributor
|
thanks @dhruvxvaishnav |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When
FileReaderuses a projection, the batches contain the projected schema butRecordBatchReader::schema()returns the complete file schema. This makes the schema reported by the reader inconsistent with the batches it produces.What changes are included in this PR?
FileReaderwhile keeping the complete schema inFileDecoderfor decoding.FileReader::schema().Are these changes tested?
Yes. I ran:
cargo test -p arrow-ipc --all-featurescargo test -p arrow --all-featurescargo clippy -p arrow-ipc --all-targets --all-features -- -D warningscargo +stable fmt --all -- --checkAre there any user-facing changes?
Yes. Projected IPC file readers now report the same schema as the record batches they produce. There are no public API signature changes.
AI assistance: OpenAI Codex assisted with codebase exploration, implementation support, test preparation, and validation. I reviewed and validated the changes and remain responsible for understanding and maintaining them.