ARROW-13705: [Website] pin node version to 16 to allow CI and local dev parity#142
Closed
jimexist wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-13705: [Website] pin node version to 16 to allow CI and local dev parity#142jimexist wants to merge 3 commits intoapache:masterfrom
jimexist wants to merge 3 commits intoapache:masterfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
jimexist
changed the title
kou
reviewed
Aug 24, 2021
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: ruby/setup-ruby@v1 | ||
| - uses: actions/setup-node@v2 |
| sh("npm", "ci") | ||
| else | ||
| sh("npm", "install", "--no-save") | ||
| end |
Member
There was a problem hiding this comment.
What is the difference of npm ci and npm install --no-save?
Member
Author
There was a problem hiding this comment.
https://docs.npmjs.com/cli/v7/commands/npm-ci#description
This command is similar to npm install, except it's meant to be used in automated environments such as test platforms, continuous integration, and deployment -- or any situation where you want to make sure you're doing a clean install of your dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pin node version to 16 to allow CI and local dev parity.
another reason for this pin is that e.g. node 16 uses npm v7 which has version 2 lock format, incompatible with prior versions.